Separate css extraction from build environment #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai2
force-pushed
the
extract-text-separation
branch
from
afb4357
to
190d6a9
Compare
|
Thanks @tai2 Could you please rebase with master? |
tai2
force-pushed
the
extract-text-separation
branch
from
190d6a9
to
f270950
Compare
tai2
force-pushed
the
extract-text-separation
branch
from
f270950
to
2f08533
Compare
|
@gauravtiwari rebased 🙏🏻 |
|
Thanks @tai2 🙏 |
|
This is a breaking change, why default false? |
|
I get why it's now a config, but I did lose a bit of time wondering why my styles suddenly broke when a stray bundle install was done on a separate branch that got merged. Definitely strongly highlight this in the readme for upgraders! |
Closed
|
I had to spend a lot of time debugging this problem. Please consider enabling this by default on all environments. |
|
Every project needs to consider how much time a change, multiplied by the number of people it affects, can be extremely costly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpacker currently tie CSS extraction to build environment. It extracts stylesheets to files when production build or development with no dev-server.
I want to separate it from build environment because CSS extraction is merely a user preference.
Some frontend developers might desire to put stylesheets in style tag or to emit separate css files using style-loader/url even in production.
These choices are reasonable in context of recent CSSinJS practices or HTTP/2 environment.
Another problem is that webpacker checks whether command line arguments contains a keyword
webpack-dev-serverto switch css extraction. It prevents to use other development tools like storybook, which contains their own webpack-dev-server, with webpacker's configuration file.I bereave this PR simplifies the condition checking logic and provides more flexible configuration.