Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #40 #246

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fix Issue #40 #246

merged 1 commit into from
Oct 5, 2017

Conversation

fl0l0u
Copy link

@fl0l0u fl0l0u commented Jul 29, 2017

Special characters combinations on non US keyboards are marked as ev.ctrlKey == true and ev.altKey == true (eg. 'AltGr' + '(' => '[' on fr-FR keyboard).

Special characters combinations on non US keyboards are marked as ev.ctrlKey == true and ev.altKey == true (eg. 'AltGr' + '(' => '[' on fr-FR keyboard).
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @gsamokovarov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Collaborator

@gsamokovarov gsamokovarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants