Let #console live in Kernel #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we can render a console from any part of an Rails application, not just in the controllers or the views. Wanna introspect a model or your plain old Ruby class? No problem! Hopefully, this change can boost up the usage of the `#console` helper. To do this juggling we now persist a binding or an exception in a fiber local variable. The middleware can create a console session from those, when needed. This is a global state, so we take precautions to clean it between requests, even in multi-threaded environments.
gsamokovarov
added a commit
that referenced
this pull request
Jan 24, 2016
Let #console live in Kernel
Like it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can render a console from any part of a Rails
application, not just in the controllers or the views. Wanna introspect
a model or your plain old Ruby class? No problem!
Hopefully, this change can boost up the usage of the
#consolehelper.To do this juggling we now persist a binding or an exception in a fiber
local variable. The middleware can create a console session from those,
when needed. This is a global state, so we take precautions to clean it
between requests, even in multi-threaded environments.