Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped integrations for CRuby and Rubinius #165

Merged
merged 4 commits into from
Sep 19, 2015

Conversation

gsamokovarov
Copy link
Collaborator

With support for Ruby 2.2.2 and above, we can get the CRuby integration running only by exposing the debug inspector API to Ruby land and using the builtin tracepoint API. This replaces binding_of_caller for the way lighter gem of debug_inspector.

While redoing the CRuby integration, I have extracted a new common interface for every integration to implement. That's WebConsole.caller_bindings and a single definition of Exception#bindings. The rubinius integration has also been changed here, as it didn't needed much work to support the new scheme.

This leaves us with the JRuby integration hanging at the moment, because I can't even start the dummy application with Rails 5 with JRuby 9.0.{0,1}.0 at the moment. I can't target 1.7 series, because of the kwargs params usage we have. I know we don't officially support it, but I like JRuby and will try to get the integration running as soon as we get 5 somehow working on it.

With support for Ruby 2.2.2 and above, we can get the integration
running only by exposing the debug inspector API to Ruby land.
Use tracepoint as we are not supporting Ruby 1.9.3 anymore.
* Implement WebConsole.caller_bindings instead of
  WebConsole::Rubinius.current_bindings.

* Drop the WebConsole::Rubinius::InternalLocationFilter class and inline
  its implementation in WebConsole.caller_bindings.
@gsamokovarov
Copy link
Collaborator Author

@sh19910711 care for a review?

@sh19910711
Copy link

@gsamokovarov Yes, I do (but please give me a little time, sorry).

@gsamokovarov
Copy link
Collaborator Author

@sh19910711 No problem, I'll let it sit here for a while.

@sh19910711
Copy link

@gsamokovarov Thanks and sorry for the delay. The new integration looks good to me :)

@gsamokovarov gsamokovarov changed the title Revamped integrations Revamped integrations for CRuby and Rubinius Sep 19, 2015
gsamokovarov added a commit that referenced this pull request Sep 19, 2015
Revamped integrations for CRuby and Rubinius
@gsamokovarov gsamokovarov merged commit 72f1466 into rails:master Sep 19, 2015
@gsamokovarov gsamokovarov deleted the revamped-integrations branch December 13, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants