Show proper binding when raising an error in a template #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
follow-original-exception
branch
6 times, most recently
from
7bf8788 to
261265c
Compare
We try to follow original exception's with `ActionDispatch::ExceptionWrapper`. However, errors like `ActionView::Template::Error` bypass ExceptionWrapper's following as they are handled specially in ActionDispatch::DebugExceptions. Thanks to David for helping catching this out.
gsamokovarov
added a commit
that referenced
this pull request
Mar 10, 2015
Show proper binding when raising an error in a template
|
@dhh, I think this will fix the template problem for you. |
gsamokovarov
added a commit
to gsamokovarov/web-console
that referenced
this pull request
Mar 11, 2015
I think the recent fixes are worth of a patch release. * [#115]: Show proper binding when raising an error in a template ([@gsamokovarov]) * [#114]: Fix templates non rendering, because of missing template suffix ([@gsamokovarov]) [#115]: rails#115 [#114]: rails#114
gsamokovarov
added a commit
to gsamokovarov/web-console
that referenced
this pull request
Mar 11, 2015
gsamokovarov
added a commit
to gsamokovarov/web-console
that referenced
this pull request
Mar 12, 2015
patrickm68
added a commit
to patrickm68/web-console
that referenced
this pull request
Dec 1, 2022
I think the recent fixes are worth of a patch release. Here are the fixes: * [#115]: Show proper binding when raising an error in a template * [#114]: Fix templates non rendering, because of missing template suffix [#115]: rails/web-console#115 [#114]: rails/web-console#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show proper binding when raising an error in a template
We try to follow original exception's with
ActionDispatch::ExceptionWrapper.However, errors like
ActionView::Template::Errorbypass ExceptionWrapper'sfollowing as they are handled specially in ActionDispatch::DebugExceptions.
Thanks to David for helping catching this out.