Switch hash from MD5 to SHA256 #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On FIPS-compliant systems (http://en.wikipedia.org/wiki/FIPS_140), MD5 cannot be used. Switch to SHA256 instead. However, this change does not keep backward compatibility with systems with already-installed Thor recipes. Closes rails#287
Closed
|
Some tests will be fixed by #771. |
|
Yeah I'm not sure this is actually a backwards compatibility issue. Looks like it just affects what filename Thor uses to save its config? Looks like it'll just save with the new filename if it can't find the old one. I'm OK with this @rafaelfranca |
|
@rafaelfranca Would you mind reviewing here? We'd like to drop uses of MD5 in our code base ASAP. |
|
@rafaelfranca Could I trouble you to release a new version with this? Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FIPS-compliant systems (http://en.wikipedia.org/wiki/FIPS_140), MD5
cannot be used. Switch to SHA256 instead.
However, this change does not keep backward compatibility with systems
with already-installed Thor recipes.
Closes #287