Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle relative source path in create_link #identical? #701

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Handle relative source path in create_link #identical? #701

merged 2 commits into from
Dec 17, 2019

Commits on Dec 16, 2019

  1. Refactor create_link_spec to allow testing varying destinations

    @chrisandreae
    chrisandreae committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    916b6aa View commit details
    Browse the repository at this point in the history

  2. Handle relative source path in create_link #identical? 

    When creating a symlink, the source path may be relative to the destination. If
this is the case, #identical? fails becase it interprets it as an absolute path.
Update #identical to resolve the source path before comparing.
    @chrisandreae
    chrisandreae committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    ae1cea9 View commit details
    Browse the repository at this point in the history