Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erikhuda/thor#587 #639

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix erikhuda/thor#587 #639

merged 1 commit into from
Nov 13, 2018

Conversation

hugocorbucci
Copy link
Contributor

@hugocorbucci hugocorbucci commented Nov 13, 2018

🌈
I bumped into the same issue @AlexandrZ in #587 had so I figured out the issue.
Problem showed itself as:

      create  bin/user_accounts
      chmod  bin/%microservice_name%
/ruby-2.4.2/lib/ruby/2.4.0/fileutils.rb:1241:in `chmod': No such file or directory @ chmod_internal - /user_accounts/bin/%microservice_name% (Errno::ENOENT)

That is, when copying a file that had a templated name with preserve mode, the path passed to the chmod command was of the original file instead of the interpreted one.

Added the spec to show the problem and the simple fix.
Let me know if you need anything else.

@rafaelfranca rafaelfranca merged commit 4344761 into rails:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants