[backport/v3.x] Make Sprockets::Utils.module_include thread safe on JRuby #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport/cherrypick of #759 to 3.x
Justification for requesting backport
module_include
appears to be used in the same way on 3.x and 4.xmanifest.js
and friends) have made migration challenging for some folks (as well as the changes folks needed to get to Rails 6.0/6.1 to even unblock Sprockets upgrade)3.x
sprockets allows some decoupling of these various upgrades without experiencing issues during live reloads as described in cannot load such file -- sass sass/sassc-rails#114 (yes,sassc
andsassc-rails
are also deprecated, but bridging support to dart sass is available in https://github.com/ntkme/sassc-embedded-shim-ruby)sass-embedded
as opposed tosass-rails
appears to increase the chance of triggering the concurrency issue this addressesIf this isn't something that will be considered for release, please feel free to note and close this PR 🙏