Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Server crash when Client times out #725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Fix Server crash when Client times out #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Next Release

* Fixed Server crash when the Client times out or otherwise disconnects

## 4.2.1

* Added `Spring.connect_timeout` and `Spring.boot_timeout` to allow to increase timeout for larger apps.
Expand Down
2 changes: 2 additions & 0 deletions lib/spring/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ def serve(client)
end
rescue SocketError => e
raise e unless client.eof?
rescue Errno::EPIPE => e
log "client disconnected with error #{e.message}, ignoring command"
ensure
redirect_output
end
Expand Down
Loading