Fix pg 1.5.0 deprecation warning

[morgoth]

Closes #48046

/cc @yahonda

[morgoth]

@yahonda Looks like the test failures are somehow related to the pg gem upgrade, so there might be some bigger problems than only deprecation warning.

[yahonda]

Right. We will need to address these two failures with pg 1.5.0 gem.

https://buildkite.com/rails/rails/builds/95886#0187b335-ed2c-4532-8176-68ae11d2a67f/1076-1087

Failure:
BasicsTest#test_preserving_time_objects_with_time_with_zone_conversion_to_default_timezone_local [/rails/activerecord/test/cases/base_test.rb:324]:
--- expected
+++ actual
@@ -1 +1 @@
-Sat, 01 Jan 2000 00:00:00.000000000 CST -06:00
+2000-01-01 01:00:00 UTC
 
 
bin/rails test /rails/activerecord/test/cases/base_test.rb:317
 
........................................F
 
Failure:
BasicsTest#test_preserving_time_objects_with_utc_time_conversion_to_default_timezone_local [/rails/activerecord/test/cases/base_test.rb:310]:
Expected: 2000-01-01 00:00:00 UTC
  Actual: 1999-12-31 19:00:00 UTC
 
bin/rails test /rails/activerecord/test/cases/base_test.rb:304

[yahonda]

Opened #48049 for these two failures.

[dima4p]

Yes, please fix it.

[yahonda]

Actually, this change is not required since Rails CI will remove the Gemfile.lock and perform a bundle install, but for clarity, Let's change the pg gem version to 1.5.1 that includes the fix for #48049
https://github.com/rails/buildkite-config/blob/cde08283a7f570c1b0185eb626f835e393350801/Dockerfile#L134

[morgoth]

@yahonda I updated the pg version

[yahonda]

Thank you for the fix.

[yahonda]

Backported to 7-0-stable branch via 71503fb

[Kaakati]

@yahonda This issue is preventing new projects from running properly, are you going to patch the current gem today?

PG::Coder.new(hash) is deprecated. Please use keyword arguments instead!

[yahonda]

No, I do not think so. You can use the 7-0-stable branch to suppress this warning if necessary.

[yahonda]

FYI Rails 7.0.5 has been released that includes this fix

rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb

Line 980 in e88857b

@timestamp_decoder = decoder_class.new(**@timestamp_decoder.to_h)

[dima4p]

FYI Rails 7.0.5 has been released that includes this fix

Thanks a lot.

[iraszl]

Will this be applied to Rails 6 as well?

[HunterMeyer]

Thanks @morgoth

[nevans]

Will this be applied to Rails 6 as well?

@iraszl It won't. Rails 6.1 only receives security fixes (see #48435 (comment)). You could use the version in #48435, but you're probably better off putting in the effort to upgrade to rails 7.0 (or temporarily downgrade pg).