Move install hooks to an install method.
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
lucasmazza
referenced
this pull request
Aug 15, 2016
While changing the code to be in an `on_load` hook fixed some of the issues with load hook order, it didn't catch all of them. Rails runs its hooks in initializers, meaning they'll be defined after our own hooks which are not in an initializer. Fixes #24
|
Yeah, let's move it to a separate file like Active Resource does: https://github.com/rails/activeresource/blob/f8abaf13174e94d179227f352c9dd6fb8b03e0da/lib/active_resource.rb#L44 (though I'd check |
|
Nice! Thanks, @lucasmazza :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I though about moving the
railtieto it's own file with adefined?check forRails::Railtie, so gems that use this for testing don't have to depend onrailtiesto load this, so if it makes sense I can push a commit for that on this branch.