Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around connect_to docs to match usage #45

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Jan 31, 2024

I noticed in the current instructions the quotes were missing for the connect_to argument so I was a bit confused on what to pass in:
Screenshot 2024-01-31 at 8 17 29 AM

This updates the docs to use connect_to "app_id:server_id" to match the actual usage.

@excid3
Copy link
Contributor Author

excid3 commented Jan 31, 2024

This should pass rubocop now @rosa 👍

Co-authored-by: Nate Matykiewicz <natematykiewicz@gmail.com>
Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏 Thanks a lot @excid3!

@rosa rosa merged commit f89efaa into rails:main Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants