Provide HTTP Basic authentication closed by default #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtschmr
reviewed
Nov 28, 2024
This asks for the username, generates and password and stores both in Rails credentials.
Generators require the whole app to be booted, which involves having access to the DB, loading all controlers, etc. which we don't need for just generating the credentials, and might not work when trying to add production credentials because many apps aren't prepared to boot for production in another environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a generator to easily set up the credentials, as it'd be closed unless configured. It can also be disabled if another authentication mechanism is used.