Fix magic detection for HTML with <svg
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursm
commented
Aug 5, 2022
Comment on lines
-2414
to
+2415
| ['application/msword', [[0..8, b["\320\317\021\340\241\261\032\341"], [[546, b['jbjb']], [546, b['bjbj']]]]]], | ||
| ['application/msword', [[2080, b['Microsoft Word 6.0 Document']], [2080, b['Documento Microsoft Word 6']], [2112, b['MSWordDoc']], [0, b["1\276\000\000"]], [0, b['PO^Q`']], [0, b["\3767\000#"]], [0, b["\333\245-\000\000\000"]], [0, b["\224\246."]], [0..8, b["\320\317\021\340\241\261\032\341"], [[1152..4096, b["W\000o\000r\000d\000D\000o\000c\000u\000m\000e\000n\000t"]]]]]], |
There was a problem hiding this comment.
These lines appear to have been replaced with L2502-L2503. I have no idea why this is happening.
|
@rafaelfranca |
sjoulbak
added a commit
to sjoulbak/marcel
that referenced
this pull request
Mar 4, 2024
This issue is introduced after merging rails#74 and released at 1.0.3. The title element provides an accessible, short-text description of the SVG and so cannot be used to determine whether an element is text/html.
|
Note this PR modifies the autogenerated tables directly. It'll be overwritten the next time Tika data is updated. I'll see whether I can fix it but will revert otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem in which HTML files containing
<svgwere misidentified as SVG.At first glance, this problem appears to be solved by adjusting the value of the priority attribute in custom.xml. However, due to the special treatment of common_types in script/generate_tables.rb, it was actually necessary to rearrange common_types itself.
Fixes #67