Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add custom font data types #37

Merged
merged 5 commits into from
Apr 2, 2021

Conversation

sbocinec
Copy link
Contributor

This PR is addressing #34 and adding some of the common used font data types to the custom data file:

  • font/otf
  • font/woff
  • font/woff2

List of changes:

  • Add additional custom font types (otf,woff,woff2)
  • Update data tables
  • Fix video/webm subclass element

Here is how the changes behave:

[1] pry(main)> Marcel::MimeType.for Pathname.new("spec/factories/fonts/regular.ttf")
=> "font/ttf"
[2] pry(main)> Marcel::MimeType.for Pathname.new("spec/factories/fonts/regular.woff")
=> "font/woff"
[5] pry(main)> Marcel::MimeType.for Pathname.new("spec/factories/fonts/regular.otf")
=> "font/otf"
[9] pry(main)> Marcel::MimeType.for extension: "woff"
=> "font/woff"
[10] pry(main)> Marcel::MimeType.for extension: "woff2"
=> "font/woff2"
[11] pry(main)> Marcel::MimeType.for extension: "otf"  
=> "application/x-font-otf"

Other notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache tika mime types used in marcel 1.0.0 missing common font types (font/woff, font/woff2,..
2 participants