Add powerpoint .ppt definition #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you have a minimal sample file that could be added as a test fixture? |
|
Was just working on making one for ya. 👍 |
|
And done! |
|
Thanks again! I just released version 0.3.2 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building a previewer for ActiveStorage, I uploaded a .ppt file I exported from Keynote. You can see in the
paramshash the content type isapplication/vnd.ms-powerpointbut once it gets to the previewer it'sapplication/x-ole-storagewhich is generic across several formats. This adds a definition for Powerpoint so those get recognized correctly.