Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using SKIP_JS_INSTALL env variable as an alias for SKIP_YARN_INSTALL/SKIP_BUN_INSTALL #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fs00
Copy link

@Fs00 Fs00 commented Feb 16, 2024

Support for NPM/PNPM was recently merged, but the name of the environment variable used to skip dependencies installation still refers to Yarn or Bun.
This PR introduces a new unified name for the environment variable: SKIP_JS_INSTALL (which aims to be consistent with SKIP_JS_BUILD introduced in #144), to avoid referring to a specific package manager.
SKIP_YARN_INSTALL and SKIP_BUN_INSTALL are obviously still there for backwards compatibility.

@Fs00 Fs00 changed the title Support skipping dependencies installation using SKIP_JS_INSTALL env variable Support using SKIP_JS_INSTALL env variable as an alias for SKIP_YARN_INSTALL/SKIP_BUN_INSTALL Jul 29, 2024
@Fs00
Copy link
Author

Fs00 commented Aug 8, 2024

I've just seen that cssbundling-rails checks those environment variables too.

Should we use different names for the environment variable between the two gems (e.g. SKIP_JS_INSTALL for jsbundling / SKIP_CSS_INSTALL for cssbundling) or do we want to find a common generic name that works for both (e.g. SKIP_DEPS_INSTALL)?
Once we've settled on a name, I can open a PR on cssbundling-rails repo too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant