Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect config.enable_reloading #172

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

ghiculescu
Copy link
Member

@ghiculescu ghiculescu commented Jan 31, 2023

Currently importmap-rails adds some file watchers even when enable_reloading is false. This PR fixes that. This way, the reloader will not run in a test environment where reloading is off by default.

Currently importmap-rails adds some file watchers even when `enable_reloading` is false. This PR fixes that.
@dhh dhh merged commit 56780fd into rails:main Jun 18, 2023
@ghiculescu ghiculescu deleted the app-reload-setting branch June 18, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants