Fix nonce attributes that were accidentally broken in PR #139 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that 243fbfb accidentally swapped `content_security_policy_nonce` with `content_security_policy`, so we're switching them back to call `content_security_policy_nonce`.
rmacklin
changed the title
This was referenced Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Addresses #139 (review)
Resolves #142 (@agrieser can you please confirm?)
Summary
It seems that #139 accidentally swapped
content_security_policy_noncewithcontent_security_policy, so we're switching them back to callcontent_security_policy_nonce.Other details
Ideally we should backfill test coverage that exercises this properly so that CI would catch this type of bug. I don't currently have the bandwidth to do so, but hopefully we can still accept this fix and someone can add that as a follow-up.