-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subclasses not inheriting headers set in the superclass #383
Conversation
The implementation of InheritedHash worked fine when look up individual keys, but when it was merged into the request headers inside the Connection class, it didn't consider the @parent_hash.
The inspection methods probably aren't necessary, but were useful at the time... |
@meanphil whaou ! Thanks for this PR. I have the same issue |
@meanphil can you add some unit tests ? |
This issue has been automatically marked as stale because it has not been commented on for at least three months. If it is an issue and you can still reproduce this error on the If it is a pull request and you are still interested on having it merged please make sure it can be merged clearly. Thank you for all your contributions. |
Sorry for the delay. Can someone add a test for the problem? |
I've added some tests, hopefully correctly! |
It's exactly the fix that I was looking for. Thank you @meanphil |
@rafaelfranca any problem with this being merged now? |
This fixes #376 - the headers weren't being shared because the InheritedHash class only works for individual key lookups.
But when the headers InheritedHash was merged into the request headers inside the Connection class it didn't consider
the @parent_hash.