Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby and Apartment versions for Rails 8.0 support #309

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

mnovelo
Copy link
Collaborator

@mnovelo mnovelo commented Jan 9, 2025

Upgrade Ruby and Apartment versions, and add new gemfiles to support Rails 8.0. Remove deprecated appraisals for earlier Rails versions.

Copy link

codecov bot commented Jan 9, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
434 5 429 0
View the top 2 failed tests by shortest run time
spec.integration.query_caching_spec query caching when use_schemas = true clears the ActiveRecord::QueryCache after switching databases
Stack Traces | 0.0143s run time
RSpec::Core::MultipleExceptionError
spec.integration.connection_handling_spec connection handling monkey patch when ActiveRecord >= 6.0 switches to the previous set tenant
Stack Traces | 0.0167s run time
RSpec::Core::MultipleExceptionError
View the full list of 1 ❄️ flaky tests
spec.tenant_spec Apartment::Tenant using mysql #adapter should load mysql adapter

Flake rate in main: 7.14% (Passed 78 times, Failed 6 times)

Stack Traces | 0.0148s run time
Failure/Error: expect(subject.adapter).to be_a(Apartment::Adapters::Mysql2Adapter)
  expected #<Apartment::Adapters::Mysql2SchemaAdapter:0x00007ff05f54a7c0 @config={adapter: "mysql2", database: "...t", min_messages: "WARNING", host: "127.0.0.1", port: 3306}, @default_tenant="apartment_mysql_test"> to be a kind of Apartment::Adapters::Mysql2Adapter
./spec/tenant_spec.rb:14:in 'block (4 levels) in <top (required)>'
..../spec/support/setup.rb:27:in 'block (2 levels) in Apartment::Spec::Setup.included'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mnovelo
Copy link
Collaborator Author

mnovelo commented Jan 9, 2025

Looks like Ruby 3.4 is not compatible with Rails 6.1 or 7. We continue to struggle to support SQLite 3.

@mnovelo mnovelo merged commit 9d95388 into development Jan 9, 2025
96 of 122 checks passed
@mnovelo mnovelo deleted the man/add-rails-8-support branch January 9, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant