Refactor unsubscribe logic to avoid unsubscribing other listeners #190
Conversation
rpbaltazar
force-pushed
the
remove-unsubscribe-activesupport-notifications
branch
from
fe5ae63 to
c4f6a84
Compare
|
@kaylareopelle please take a look at this PR and help me check if this does not impact your gem's implementation. I've tried to follow a similar approach used by lograge to unsubscribe specific event listener |
|
I have looked through the new_relic's gem source code and I don't think you're relying anyhow on ActiveRecord::LogSubscriber specifically, so I think this is a safe solution to push forward. Please re-open the ticket if that is not the case. |
|
@rpbaltazar - Thank you for this fix! It looks like it should avoid the issues we were previously seeing with the agent. My apologies for the lack of response over the weekend! I'll share this with a customer that raised the conflict and let you know how it goes. |
|
No problem. My time available for OSS varies a lot throughout the year, thus trying to power through a few issues once i have time avail. Thank you for this! 🔥 |
Resolves #189