[#170] cache key breaks when receiving a belongs to reflection #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpbaltazar
force-pushed
the
170-no-implicit-conversion
branch
from
592e5f8 to
ecc74e8
Compare
rpbaltazar
added a commit
that referenced
this pull request
Sep 13, 2021
**Implemented enhancements:** - #112 - Allow a list of schemas when switching using schemas - #154 - Create schema between different versions of DB - #155 **Fixed bugs:** - #170 - Cache Key breaks on rails 6.0.4 - #171 **Closed issues:** - Add ruby 3 to the build matrix - #162 - update rubocop and fixed broken rules - #157 - added junit formatter and saving test output in circle - #172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address issue reported in #170
Tests in production application are working with this fix, but:
checked what changed between rails 6.0.3 and 6.0.4 and here is the commit that causes the changes to break: rails/rails@45081c9#diff-b1aed4985f41ad87dc1be30472b728a19f1a7354f25ce71bf6ce9a7744a9cd0dR445
rails internally uses the concurrent map implementation. The concurrent map implementation uses whatever values passed as keys, so converting the reflection instance to an array with the tenant should be safe