[WIP] Add config for handling tenant creation on db:migrate

[jonian]

This is a proposal to resolve issue #136 by making the create_tenant on db:migrate behavior configurable. Added config key db_migrate_tenant_missing_strategy defaulting to rescue_exception with available options:

• rescue_exception
• raise_exception
• create_tenant

The default option has the same behavior as it was before version 2.8.0. If this is ok, I can procceed to add specs for the new config option.

[Aesthetikx]

Thanks for working on this, I ran into (with 2.8.1) a bunch of tried to create tenant errors (although they were handled and did not crash) when otherwise I would have had no output other than 'migrating xyz tenant'. To be clear, to get the old behavior, would that be the 'rescue exception' option?

[jonian]

Yes rescue_exception is the old behavior, you get a tenant not found message and the task continues to the next tenant.

There is no check for rescue_exception in this PR and it can be replaced by nil or do_nothing or whatever sounds better.

Code before 2.8.0

def self.migrate_tenant(tenant_name)
  puts("Migrating #{tenant_name} tenant")
  Apartment::Migrator.migrate tenant_name
rescue Apartment::TenantNotFound => e
  puts e.message
end

Code after 2.8.0

def self.migrate_tenant(tenant_name)
  create_tenant(tenant_name) # create tenant was added

  puts("Migrating #{tenant_name} tenant")
  Apartment::Migrator.migrate tenant_name
rescue Apartment::TenantNotFound => e
  puts e.message
end

Code in this PR

def self.migrate_tenant(tenant_name)
  strategy = Apartment.db_migrate_tenant_missing_strategy
  create_tenant(tenant_name) if strategy == :create_tenant # enables behavior like in 2.8.0

  puts("Migrating #{tenant_name} tenant")
  Apartment::Migrator.migrate tenant_name
rescue Apartment::TenantNotFound => e
  raise e if strategy == :raise_exception # new behavior if you want to stop the migration

  puts e.message
end

[rpbaltazar]

Thank you for working on this. looks great! 👍