Add support for Ruby 2.6, configure sqlite3 to use ~> 1.4 for rails 6+, patch for Rails 4.2 against Ruby 2.6 #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasifhossain
force-pushed
the
ruby-2-6-rails-4-2-test-patch
branch
from
c2c7e6d to
5d122f2
Compare
|
wow! travis looks 💯 ✔️ |
wasifhossain
changed the title
wasifhossain
added a commit
that referenced
this pull request
Apr 23, 2019
wasifhossain
added a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
mastertests pass against Ruby 2.5+Changes
.travis.ymlsqlite3gem to use~> 1.4for Rails 6+Caveats
Related GitHub issues
Additional helpful information
execute_batch2rather thanexecute_batchto fix performance regression for fixture loading rails/rails#35844