-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Serialize resource type for unpersisted records (blank id) #2216
Conversation
Thanks! |
looks good! |
Anything else before I release a 0.10.7? I think the only other regression is #2178 |
Terrific! Thank you for this, and for including the CC in the related PR. |
Awesome, thanks @bf4 ! |
@@ -38,8 +39,11 @@ def initialize(serializer, options) | |||
end | |||
|
|||
def as_json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arguably, if serializer.object
is nil, the return value should be nil
, not { type: type}
, and consider it a 'nil' identifier
Current behavior when
id
is nil returns:{data: null}
Closes #2132
Closes #2180
Regression from v0.10.5 to v0.10.6
Incidental changes in the PR