Favor ActiveSupport::TestCase over Minitest::Test #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bf4
commented
Dec 20, 2015
bf4
commented
- Better minitest 4/5 support
- Better DSL
- Already available with no changes
- Consistent interface
- Better minitest 4/5 support - Better DSL - Already available with no changes - Consistent interface
bf4
force-pushed
the
remove_raw_minitest_test
branch
from
fb7ad07 to
419faf0
Compare
bf4
referenced
this pull request
Dec 23, 2015
|
What would be the drawbacks? |
|
@beauby I have no idea what the drawback would be. I do know that at one point AS::TC was removed in favor of raw minitest. Perhaps speed? |
|
After investigating a bit, it appears |
|
It's ok to merge this, when I was building AMS 0.10 I used Minitest::Test just because I didn't need AS::TC and wanted to depend as minimum as possible on Rails stuff. |
|
Great, thanks for the heads up @spastorino. As 0.10 is already depending on quite a bit of rails stuff, I don't believe this PR will hurt much, so I'm merging. |
beauby
added a commit
that referenced
this pull request
Dec 30, 2015
Favor ActiveSupport::TestCase over Minitest::Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.