Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add_links in JSONAPI adapter. #1121

Merged
merged 2 commits into from
Sep 15, 2015

Conversation

beauby
Copy link
Contributor

@beauby beauby commented Sep 7, 2015

  • Moved the paginated? method in the ArraySerializer
  • Refactored add_links into links_for in order to be consistent with the refactor of the adapter (Refactor JSONAPI adapter #1103)

@@ -29,6 +29,12 @@ def json_key
key = root || @serializers.first.try(:json_key) || object.try(:name).try(:underscore)
key.try(:pluralize)
end

def paginated?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joaomdmoura
Copy link
Member

Nice, I'm merging this one 😄

joaomdmoura added a commit that referenced this pull request Sep 15, 2015
Refactor `add_links` in JSONAPI adapter.
@joaomdmoura joaomdmoura merged commit 479146c into rails-api:master Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants