Update pip-tools #5987
Merged
Update pip-tools #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying for linux users to manually make sure that it stays included every time they compile the deps. It's only required for MacOS systems and we don't want to have it in the diff every time it is compiled on a different OS.
palango
reviewed
Mar 13, 2020
requirements/requirements-dev.txt
Outdated
| @@ -4,182 +4,182 @@ | |||
| # | |||
| # './deps compile' (for details see README) | |||
| # | |||
| alabaster==0.7.12 | |||
| aniso8601==7.0.0 | |||
| alabaster==0.7.12 # via -r /home/karl/raiden/requirements/requirements-docs.txt, sphinx | |||
There was a problem hiding this comment.
Can we somehow avoid having anyone's username in there? Otherwise the diff will be this big for every change from different people.
There was a problem hiding this comment.
Uh, that's wrong of course! Why did it put the full path in there? I'll see if I can change that.
There was a problem hiding this comment.
Looks like others have the same problem. Why does it work for dependabot, see #5986 and jazzband/pip-tools#1067?
There was a problem hiding this comment.
I assume the reason is that our wrapper script (that handles the dependency resolution between the files) passes absolute paths.
I'll see if that is easily fixable.
The diff is so big due to jazzband/pip-tools#1058.
To prevent absolute paths in our pip-compile output we now pass paths relative to the working directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is so big due to jazzband/pip-tools#1058 and I wanted to avoid having that diff inside another PR. I also explicitly excluded
macholibas a ci dependency to avoid differences between MacOS and linux machines.