Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode addresses as checksums with web3 #5700

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Don't encode addresses as checksums with web3 #5700

merged 1 commit into from
Jan 20, 2020

Conversation

palango
Copy link
Contributor

@palango palango commented Jan 20, 2020

This isn't necessary since ethereum/web3.py#893

@auto-assign auto-assign bot requested a review from hackaugusto January 20, 2020 08:56
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #5700 into develop will decrease coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5700      +/-   ##
===========================================
- Coverage    79.58%   79.22%   -0.36%     
===========================================
  Files          131      131              
  Lines        15139    15139              
  Branches      2313     2313              
===========================================
- Hits         12048    11994      -54     
- Misses        2441     2480      +39     
- Partials       650      665      +15
Flag Coverage Δ
#integration 62.52% <100%> (-11.07%) ⬇️
#unit 55.71% <0%> (+0.01%) ⬆️
Impacted Files Coverage Δ
raiden/network/proxies/token_network.py 44.29% <ø> (-3.85%) ⬇️
raiden/network/proxies/token.py 56.86% <100%> (ø) ⬆️
raiden/network/proxies/user_deposit.py 43.61% <100%> (+1.06%) ⬆️
raiden/network/proxies/token_network_registry.py 48.85% <100%> (-1.15%) ⬇️
raiden/utils/echo_node.py 68.9% <0%> (+1.68%) ⬆️
raiden/network/resolver/client.py 77.08% <0%> (ø) ⬆️
raiden/connection_manager.py 73.17% <0%> (ø) ⬆️
raiden/blockchain/state.py 94.33% <0%> (+1.88%) ⬆️
raiden/blockchain/decode.py 98.52% <0%> (ø) ⬆️
raiden/messages/encode.py 95% <0%> (ø) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c269e...2773f37. Read the comment docs.

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palango palango merged commit 4e60b23 into raiden-network:develop Jan 20, 2020
@palango palango deleted the use-bytes-with-web3 branch January 20, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants