Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constant functions to TokenNetworkUtils library #264

Closed
wants to merge 5 commits into from
Closed

Move constant functions to TokenNetworkUtils library #264

wants to merge 5 commits into from

Conversation

loredanacirstea
Copy link
Contributor

@loredanacirstea loredanacirstea commented Sep 17, 2018 •
edited
Loading

Issue: TokenNetworkRegistry bytecode is too big for deployment if we try to implement #262 and #263

We might go with either:

Please do not merge this until I have the contract limits PR functional on top of this one.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@loredanacirstea loredanacirstea force-pushed the library-split branch 7 times, most recently from 717c660 to f2417a8 Compare September 18, 2018 12:29
@loredanacirstea loredanacirstea mentioned this pull request Sep 18, 2018
Merged
@loredanacirstea
Split helper functions into a separate TokenNetworkUtils library
71b1f49
@loredanacirstea
Fix TokenNetworkRegistry deployment after code splitting
09bce7f 
- link the TokenNetworkUtils library
@loredanacirstea
- was moved to TokenNetworkUtils library
b8b5dad 
Make library functions public, avoid memory struct
@loredanacirstea
Use a separate instance for ContractManager for each test
ffd5071 
- we need to compile the TokenNetworkRegistry contract for each test, due to linking the TokenNetworkUtils library (the address is changed for each test)
@loredanacirstea
Refactor fixtures
a38c633
@loredanacirstea loredanacirstea mentioned this pull request Nov 12, 2018
Open
@loredanacirstea loredanacirstea mentioned this pull request Jan 7, 2019
Closed
@pirapira
Copy link
Contributor

@loredanacirstea I'll take ideas from this PR, once I see too big code.

@pirapira
Copy link
Contributor

Somehow we have both #262 and #263 and the codesize is still within the limit. Perhaps the compiler got a lot better these days.

@pirapira pirapira closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loredanacirstea @CLAassistant @pirapira