This repository has been archived by the owner on May 13, 2022. It is now read-only.
Support for eth_signTypedData in crypto.py #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devium
force-pushed
the
eth_sign_typed_data_python
branch
from
379c6e2 to
4fa02d4
Compare
loredanacirstea
approved these changes
Nov 28, 2017
This was referenced Nov 28, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
eth_sign_typed_data_message()eth_sign_typed_data()eth_sign_typed_data_message_eip()eth_sign_typed_data_eip()for the proposed
eth_signTypedDatafunction. The versions suffixed byeipfollow the actual EIP specification while those without follow the current implementation ofeth_signTypedDataused in Metamask.eth_signTypedData - add verifyBalanceProofPrepend() ; prepend schema hash #181
On a side note:
pack()now also supports bools \o/