Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk,cli: expose contracts info in SDK and provide /contracts endpoint in CLI #1913

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

andrevmatos
Copy link
Contributor

Part of #1692

Short description
Implements /contracts endpoint. Still undocumented on spec, but offered by python API.

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

@andrevmatos andrevmatos added sdk 🖥 cli 🔤 Command-line SDK-based Node.js Client issues labels Jul 15, 2020
@andrevmatos andrevmatos self-assigned this Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1913 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         155      155           
  Lines        5796     5798    +2     
  Branches     1089     1090    +1     
=======================================
+ Hits         5542     5544    +2     
  Misses        196      196           
  Partials       58       58           
Flag Coverage Δ
#dapp 91.76% <ø> (ø)
#sdk 97.21% <100.00%> (+<0.01%) ⬆️
#sdk_e2e 65.53% <100.00%> (+0.06%) ⬆️
#sdk_unit 86.40% <0.00%> (-0.05%) ⬇️
Impacted Files Coverage Δ
raiden-ts/src/raiden.ts 91.52% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f37eae...a904c68. Read the comment docs.

@andrevmatos andrevmatos force-pushed the feature/cli_contracts_version branch from 5c8eb77 to bd34bb9 Compare July 15, 2020 22:04
Copy link
Contributor

@weilbith weilbith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

raiden-cli/src/routes/api.v1.ts Show resolved Hide resolved
raiden-cli/src/routes/api.v1.ts Show resolved Hide resolved
@andrevmatos andrevmatos force-pushed the feature/cli_contracts_version branch from 35736c0 to c2b5b36 Compare July 16, 2020 12:59
@andrevmatos andrevmatos force-pushed the feature/cli_contracts_version branch from c2b5b36 to a904c68 Compare July 16, 2020 13:00
@andrevmatos andrevmatos merged commit 53f4d0e into master Jul 16, 2020
@andrevmatos andrevmatos deleted the feature/cli_contracts_version branch July 16, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues sdk 🖥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants