Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: implement pending_transfers endpoint and fix /status #1909

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

andrevmatos
Copy link
Contributor

Part of #1692

Short description
Title.

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

  1. Test /api/v1/pending_transfers/ endpoints work as per spec

@andrevmatos andrevmatos added the cli 🔤 Command-line SDK-based Node.js Client issues label Jul 15, 2020
@andrevmatos andrevmatos self-assigned this Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1909   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         155      155           
  Lines        5793     5793           
  Branches     1089     1031   -58     
=======================================
  Hits         5539     5539           
  Misses        196      196           
  Partials       58       58           
Flag Coverage Δ
#dapp 91.76% <ø> (ø)
#sdk 97.21% <ø> (ø)
#sdk_e2e 65.46% <ø> (+0.02%) ⬆️
#sdk_unit 86.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36efe62...6178125. Read the comment docs.

Copy link
Contributor

@weilbith weilbith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A complete new endpoint. 🎉
We need to take care and don't introduce inconsistencies into the code-base at already such an early stage.

raiden-cli/src/routes/pendingTransfers.ts Show resolved Hide resolved
raiden-cli/src/routes/pendingTransfers.ts Show resolved Hide resolved
raiden-cli/src/routes/pendingTransfers.ts Show resolved Hide resolved
raiden-cli/src/routes/pendingTransfers.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants