-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: implement channel deposit, close, settle and fix some issues with channels interface #1903
Conversation
You modified |
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 155 155
Lines 5791 5791
Branches 1090 1089 -1
=======================================
Hits 5540 5540
Misses 193 193
Partials 58 58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this feature. I was kinda afraid to do so back then. Happy that is comes now.
5fb5740
to
de8c391
Compare
de8c391
to
98890fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks that you did all the adjustments according to my review requests. I highly appreciate that!! 🙏
Part of #1692
Short description
Extend the channel part of the CLI:
balance
field contains what is calledcapacity
on the SDK, i.e. the amount which can still be transferred on the channelstate
contains a different set of strings:opened
,closed
,settled
, so we need to adapt our more descriptive state to theseid
,settleTimeout
andrevealTimeout
PATCH
method on the channels endpoint:{ "state": "closed"|"settled" }
respectively closes and settles the channel{ "total_deposit": "<number>" }
deposits amout which takes the total deposit to the requested amount{ "total_withdral": "<number>" }
withdraws amount which brings total withdraw to the requested amountDefinition of Done
Steps to manually test the change (dApp)