Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for setLevel on undefined logger #1245

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Workaround for setLevel on undefined logger #1245

merged 4 commits into from
Mar 27, 2020

Conversation

andrevmatos
Copy link
Contributor

Try to fix #1232
Also, fixes logstore for errors on Firefox

@andrevmatos andrevmatos self-assigned this Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1245 into master will increase coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
+ Coverage   95.00%   95.65%   +0.64%     
==========================================
  Files         117      117              
  Lines        4145     4120      -25     
  Branches      850      842       -8     
==========================================
+ Hits         3938     3941       +3     
+ Misses        164      136      -28     
  Partials       43       43              
Flag Coverage Δ
#dapp 90.83% <ø> (+2.12%) ⬆️
#sdk 97.56% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
raiden-dapp/src/utils/logstore.ts 20.00% <ø> (+13.02%) ⬆️
raiden-ts/src/polyfills.ts 100.00% <100.00%> (ø)
raiden-ts/src/raiden.ts 93.87% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee37f8...74a658f. Read the comment docs.

Copy link
Contributor

@nephix nephix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Copy link
Contributor

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nephix nephix merged commit d62fb9a into master Mar 27, 2020
@nephix nephix deleted the issue/1232 branch March 27, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp keeps redirecting to splash screen after connecting
3 participants