Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

内部実装を UICollectionView に変更 #2

Merged
merged 13 commits into from
Dec 18, 2022
Merged

Conversation

ragingo
Copy link
Owner

@ragingo ragingo commented Dec 18, 2022

UITableView & iOS 14.5 でセクションフッタの高さが狂う問題があった。
UICollectionView に切り替えてみたところその問題が解消された。

@ragingo ragingo marked this pull request as draft December 18, 2022 04:44
}

func scrollToTop(animated: Bool = true) {
uiCollectionView.scrollToItem(at: .init(row: 0, section: 0), at: .top, animated: animated)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

左: iOS 16.1 / 右: iOS 14.5

iOS 14.5... 😇
セクションの高さ分の移動が足りない・・・

image

@ragingo
Copy link
Owner Author

ragingo commented Dec 18, 2022

UITableView のときとほぼ同じ動作を再現できたからこれで一旦完了。

📝 separator の insets と color の変更は 14.5+ という制限は増えてしまった

@ragingo ragingo marked this pull request as ready for review December 18, 2022 05:41
@ragingo ragingo merged commit e329bbc into main Dec 18, 2022
@ragingo ragingo deleted the feature/collectionview branch December 18, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant