Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump awscli from 1.20.3 to 1.20.9 in /tdrs-backend #1164

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jul 29, 2021

Bumps awscli from 1.20.3 to 1.20.9.

Changelog

Sourced from awscli's changelog.

1.20.9

  • api-change:sso-admin: Documentation updates for arn:aws:trebuchet:::service:v1:03a2216d-1cda-4696-9ece-1387cb6f6952
  • api-change:cloudformation: SDK update to support Importing existing Stacks to new/existing Self Managed StackSet - Stack Import feature.
  • enhancement:eks: Updated Kubernetes client authentication API version

1.20.8

  • api-change:route53: This release adds support for the RECOVERY_CONTROL health check type to be used in conjunction with Route53 Application Recovery Controller.
  • api-change:route53-recovery-control-config: Amazon Route 53 Application Recovery Controller's routing control - Routing Control Configuration APIs help you create and delete clusters, control panels, routing controls and safety rules. State changes (On/Off) of routing controls are not part of configuration APIs.
  • api-change:iotwireless: Add SidewalkManufacturingSn as an identifier to allow Customer to query WirelessDevice, in the response, AmazonId is added in the case that Sidewalk device is return.
  • api-change:iotanalytics: IoT Analytics now supports creating a dataset resource with IoT SiteWise MultiLayerStorage data stores, enabling customers to query industrial data within the service. This release includes adding JOIN functionality for customers to query multiple data sources in a dataset.
  • api-change:route53-recovery-cluster: Amazon Route 53 Application Recovery Controller's routing control - Routing Control Data Plane APIs help you update the state (On/Off) of the routing controls to reroute traffic across application replicas in a 100% available manner.
  • api-change:route53-recovery-readiness: Amazon Route 53 Application Recovery Controller's readiness check capability continually monitors resource quotas, capacity, and network routing policies to ensure that the recovery environment is scaled and configured to take over when needed.
  • api-change:redshift-data: Added structures to support new Data API operation BatchExecuteStatement, used to execute multiple SQL statements within a single transaction.
  • api-change:lexv2-models: Update lexv2-models command to latest version
  • api-change:quicksight: Add support to use row-level security with tags when embedding dashboards for users not provisioned in QuickSight
  • api-change:batch: Add support for ListJob filters
  • api-change:shield: Change name of DDoS Response Team (DRT) to Shield Response Team (SRT)

1.20.7

  • api-change:identitystore: Documentation updates for SSO API Ref.
  • api-change:cloudwatch: Update cloudwatch command to latest version
  • api-change:synthetics: CloudWatch Synthetics now supports visual testing in its canaries.
  • api-change:s3control: S3 Access Point aliases can be used anywhere you use S3 bucket names to access data in S3
  • api-change:proton: Documentation-only update links
  • api-change:textract: Adds support for AnalyzeExpense, a new API to extract relevant data such as contact information, items purchased, and vendor name, from almost any invoice or receipt without the need for any templates or configuration.

1.20.6

  • api-change:s3outposts: Add on-premise access type support for endpoints
  • api-change:securityhub: Added product name, company name, and Region fields for security findings. Added details objects for RDS event subscriptions and AWS ECS services. Added fields to the details for AWS Elasticsearch domains.
  • api-change:imagebuilder: Update to documentation to reapply missing change to SSM uninstall switch default value and improve description.

1.20.5

  • api-change:elbv2: Update elbv2 command to latest version
  • api-change:databrew: This SDK release adds two new features: 1) Output to Native JDBC destinations and 2) Adding configurations to profile jobs
  • api-change:s3control: Documentation updates for Amazon S3-control
  • api-change:qldb: Amazon QLDB now supports ledgers encrypted with customer managed KMS keys. Changes in CreateLedger, UpdateLedger and DescribeLedger APIs to support the changes.

... (truncated)

Commits
  • b82ba41 Merge branch 'release-1.20.9'
  • 30289f4 Bumping version to 1.20.9
  • e1a291c Update changelog based on model updates
  • 1b1fa0e Merge pull request #6289 from micahhausler/eks-get-token-update
  • 3569d49 [customizations/eks]: Update credential API version
  • 01f1cdd Merge branch 'release-1.20.8'
  • 7d26efd Merge branch 'release-1.20.8' into develop
  • a635832 Bumping version to 1.20.8
  • 17dad3a Update changelog based on model updates
  • 8d93b67 Merge pull request #6279 from kdaily/timeout-default-documentation
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [awscli](https://github.com/aws/aws-cli) from 1.20.3 to 1.20.9.
- [Release notes](https://github.com/aws/aws-cli/releases)
- [Changelog](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst)
- [Commits](aws/aws-cli@1.20.3...1.20.9)

---
updated-dependencies:
- dependency-name: awscli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added backend dependencies Pull requests that update a dependency file raft review This issue is ready for raft review labels Jul 29, 2021
@dependabot dependabot bot requested a review from a team July 29, 2021 06:22
@dependabot dependabot bot requested a review from ADPennington July 29, 2021 06:22
@jtwillis92
Copy link

@abottoms-coder @ADPennington perhaps we should consider just merging this particular package as it gets updates? As it's a dev dependency only used for setting up localstack it is a pretty low risk. Since this package gets updated so often we seem to be falling behind in the typical review process. When a newer version is available Dependabot will close the PR and open a new one in its place. We've already superseded 5 updates for this package since the Dependabot Mass Merge.

@jtwillis92 jtwillis92 added QASP Review and removed raft review This issue is ready for raft review labels Jul 29, 2021
@ADPennington
Copy link
Collaborator

@abottoms-coder @ADPennington perhaps we should consider just merging this particular package as it gets updates? As it's a dev dependency only used for setting up localstack it is a pretty low risk. Since this package gets updated so often we seem to be falling behind in the typical review process. When a newer version is available Dependabot will close the PR and open a new one in its place. We've already superseded 5 updates for this package since the Dependabot Mass Merge.

I was planning to at least move toward a weekly qasp review of this one given how often it is updated. but i'm open to this approach to help ensure devs have the latest. this does raise a broader question for me though: should we consider this approach for other/all dev dependencies? @jtwillis92 @abottoms-coder

@jtwillis92
Copy link

should we consider this approach for other/all dev dependencies? @jtwillis92 @abottoms-coder

I would vote yes, as long as the tests pass. These dependencies won't be installed in deployed environments:

❯ cf ssh tdp-backend-staging                                                                                                                                                                                    ─╯
vcap@343fa144-3b8f-4280-727f-3e68:~$ /tmp/lifecycle/shell
vcap@343fa144-3b8f-4280-727f-3e68:~$ python manage.py shell_plus
...truncated...
IPython 7.25.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import awscli
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-2908b588e03d> in <module>
----> 1 import awscli

ModuleNotFoundError: No module named 'awscli'

In [2]: import flake8
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-e3c0e6d2367d> in <module>
----> 1 import flake8

ModuleNotFoundError: No module named 'flake8'

In [3]: import pytest
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-3-2d357f508617> in <module>
----> 1 import pytest

ModuleNotFoundError: No module named 'pytest'

vs local:

❯ docker-compose exec web /bin/bash                                                                                                                                                                             ─╯
root@989f846ed643:/tdpapp# python manage.py shell_plus
...truncated...
IPython 7.24.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import flake8

In [2]: import pytest

In [3]: import awscli

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1164 (e20c648) into raft-tdp-main (e238031) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           raft-tdp-main    #1164   +/-   ##
==============================================
  Coverage          98.13%   98.13%           
==============================================
  Files                 38       38           
  Lines                910      910           
  Branches              41       41           
==============================================
  Hits                 893      893           
  Misses                12       12           
  Partials               5        5           
Flag Coverage Δ
dev-backend 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e238031...e20c648. Read the comment docs.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 30, 2021

A newer version of awscli exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@andrew-jameson andrew-jameson merged commit 5bb6d9a into raft-tdp-main Jul 30, 2021
@andrew-jameson andrew-jameson deleted the dependabot/pip/tdrs-backend/raft-tdp-main/awscli-1.20.9 branch July 30, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file QASP Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants