syncthing_folder: Always update the devices the folder is shared with #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure all devices the folder should be shared with is part of the folder configuration. Previously, only at folder creation would the devices be set.
The folder configuration is parametrized in one place, no need for duplicates.
Accept the `ignore_perms` flag matching the `folder.ignorePerms` attribute.
Accept the `type` value matching the `folder.type` attribute.
Accept the `fs_watcher` flag matching the `folder.fsWatcherEnabled` attribute.
Specifying `config_file` overrides the default path relative to the current user. This is handy when the executing user is a different user.
Specifying `config_file` overrides the default path relative to the current user. This is handy when the executing user is a different user.
Keep the existing list of devices if it contains the expected devices. This change fixes the current/expected configurations comparison on devices ordering.
When defining a new shared folder, the configuration is missing and thus there are no current devices configured.
There is no need to require that the device being configured is explictly mentioned in its configuration. We can get it through the status endpoint and automatically add it to the set of devices the folder is shared with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all devices the folder should be shared with is part of the
folder configuration.
Previously, only at folder creation would the devices be set.