Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mixing of macros that are defined in a different name space #10

Merged
merged 1 commit into from
May 16, 2022

Conversation

hhaensel
Copy link
Contributor

Currently, it is not possible to do

@mix Stipple.@with_kw mutable struct reactive
  Stipple.@reactors
end

as Stipple.@with_kw is not a Symbol but an expression. Therefore, it is currently not possible to use macros for mixing that are not available in the current name space. Changing the array type as proposed cures that short coming.

Currently, it is not possible to do
```julia
@mix Stipple.@with_kw mutable struct reactive
  Stipple.@reactors
end
```
as `Stipple.@with_kw` is not a Symbol but an expression. Therefore, it is currently not possible to use macros for mixing that are not available in the current name space. Changing the array type as proposed cures that short coming.
@rafaqz rafaqz merged commit c7bd255 into rafaqz:master May 16, 2022
@rafaqz
Copy link
Owner

rafaqz commented May 16, 2022

Thanks!

@hhaensel
Copy link
Contributor Author

Thanks for reacting so quickly 🚀
I updated our code already 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants