Make sure Release script in fact commits before tagging, otherwise ta… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gging is meaningless, CD did not work because the released tag did not contain the updated checksum and path in Package.swift (since we did not commit before tagging...).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7 +/- ##
========================================
Coverage 99.06% 99.06%
========================================
Files 128 128
Lines 2891 2891
========================================
Hits 2864 2864
Misses 27 27 ☔ View full report in Codecov by Sentry. |
GhenadieVP
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gging is meaningless, CD did not work because the released tag did not contain the updated checksum and path in Package.swift (since we did not commit before tagging...).
Hopefully this is the last missing piece!