Swift Build Script | CD release pipeline #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4 +/- ##
===========================================
- Coverage 99.27% 99.13% -0.15%
===========================================
Files 120 120
Lines 2634 2663 +29
===========================================
+ Hits 2615 2640 +25
- Misses 19 23 +4 ☔ View full report in Codecov by Sentry. |
CyonAlexRDX
force-pushed
the
build_scrip_and_CD
branch
from
d74ec2e
to
0269a74
Compare
| @@ -11,26 +11,26 @@ use radix_engine_common::math::Decimal as ScryptoDecimal; | |||
| DeserializeFromStr, | |||
| uniffi::Record, | |||
| )] | |||
| pub struct Decimal { | |||
| pub struct Decimal192 { | |||
There was a problem hiding this comment.
@CyonAlexRDX Why did you rename it? Was there any problem with the build?
There was a problem hiding this comment.
Clash with Swift Foundations type with same name. So in iOS app in a file where we import
Both Sargon and Foundation it does not compile. And I don't wanna have to write Sargon.Decimal all over the place.
CyonAlexRDX
force-pushed
the
build_scrip_and_CD
branch
from
74e1a88
to
964257f
Compare
CyonAlexRDX
force-pushed
the
build_scrip_and_CD
branch
from
964257f
to
b3f6f69
Compare
CyonAlexRDX
force-pushed
the
build_scrip_and_CD
branch
from
3d5b01c
to
b798cef
Compare
CyonAlexRDX
force-pushed
the
build_scrip_and_CD
branch
from
b798cef
to
056f3f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.