Wrap RET: batch 9 (ManifestSummary) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructors employing impl Into<Decimal> and Into<SomeAddress> to greatly decrease LOC in tests using addresses and amounts.
…t panic on Decimal::MIN, instead return DECIMAL::MAX.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24 +/- ##
========================================
Coverage 99.32% 99.32%
========================================
Files 211 211
Lines 5025 5029 +4
========================================
+ Hits 4991 4995 +4
Misses 34 34 ☔ View full report in Codecov by Sentry. |
micbakos-rdx
approved these changes
Mar 15, 2024
| #[derive(Clone, Debug, PartialEq, Eq, uniffi::Record)] | ||
| pub struct ManifestSummary { | ||
| pub addresses_of_accounts_deposited_into: Vec<AccountAddress>, | ||
| /// Addresses of accounts withdraws from in the manifest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Target branch is
Batch 8, merge #23 first )Impl of
ManifestSummary, you probably want to review only the first commit.The second commit just makes Address types impl Copy, so we can drop a lot of
clone()calls.The third commit is smaller and similar, adds Copy for PublicKeys