Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix third party deposit manifest #149

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

CyonAlexRDX
Copy link
Contributor

Fix bug present in Production, user is unable to update Third Party Deposit settings by removing depositor.

This fixes that.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (5358f14) to head (1ca2dfd).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #149   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files        742     742           
  Lines      11221   11223    +2     
  Branches      26      26           
=====================================
+ Hits       11103   11105    +2     
  Misses       118     118           
Flag Coverage Δ
kotlin 100.0% <ø> (ø)
rust 98.6% <100.0%> (+<0.1%) ⬆️
swift 99.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...osit_update/manifest_third_party_deposit_update.rs 100.0% <ø> (ø)
...party_deposit_update/third_party_deposits_delta.rs 100.0% <100.0%> (ø)

@jakub-rdx
Copy link
Contributor

@CyonAlexRDX sneaky one

@CyonAlexRDX CyonAlexRDX merged commit 1195c5d into main May 27, 2024
10 checks passed
@CyonAlexRDX CyonAlexRDX deleted the fix_third_party_deposit_manifest branch May 27, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants