feature: Added PreviewTransactionV2
#1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
dhedey
changed the title
PreviewTransactionIntentV2PreviewTransactionIntentV2
Benchmark for 052893bClick to view benchmark
|
dhedey
changed the title
PreviewTransactionIntentV2PreviewTransactionV2
dhedey
changed the base branch from
feature/allow-v1-transactions-to-still-duplicate-notary
to
develop
iamyulong
reviewed
Oct 29, 2024
| .iter() | ||
| .zip(non_root_subintent_signatures) | ||
| .enumerate() | ||
| { |
There was a problem hiding this comment.
We're not validating the length of signatures?
There was a problem hiding this comment.
This happens on line 1394 inside add_non_root because it's shared logic - and I believe there are existing tests that cover this.
There was a problem hiding this comment.
If there aren't explicit tests for subintent signatures, I'll add them 👍
There was a problem hiding this comment.
I vaguely remember that I added such a test.
There was a problem hiding this comment.
too_many_signatures_should_be_rejected
There was a problem hiding this comment.
We missed a test on signature count on the root manifest, so I've added that.
iamyulong
reviewed
Oct 29, 2024
| .located(TransactionValidationErrorLocation::AcrossTransaction), | ||
| ); | ||
| } | ||
| for (index, (subintent, signatures)) in non_root_subintents |
There was a problem hiding this comment.
Minor: signatures => public_keys
iamyulong
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for a
PreviewTransactionV2, and the preview API in the node will use its payload bytes (a slight pivot from V1 where the preview model was taken in JSON). It can be created from theTransactionV2Builder.This PR also includes various refactors to the
TransactionValidatoras part of enabling validation ofPreviewTransactionV2s:And also took on another small refactor:
assert_matches!(..)macro so we get better test output on failure for lots of tests.Testing
preview_v2.rs