-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base cost to consume_wasm_execution_units host function #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker tags |
Benchmark for 4af62f6Click to view benchmark
|
dhedey
reviewed
Oct 25, 2024
lrubasze
force-pushed
the
tweak/wasm-costing
branch
2 times, most recently
from
October 28, 2024 22:40
51995b2
to
9ff6fc8
Compare
lrubasze
force-pushed
the
tweak/wasm-costing
branch
2 times, most recently
from
October 29, 2024 11:01
3b9c893
to
59c0797
Compare
iamyulong
changed the title
Tweak/wasm costing
Add base cost to consume_wasm_execution_units host function
Oct 29, 2024
lrubasze
force-pushed
the
tweak/wasm-costing
branch
from
October 29, 2024 11:41
59c0797
to
3688b51
Compare
iamyulong
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added WASM execution unit base to assure simple WASM calls are not being undercharged.
Motivation
Based on the benchmarks on the
base
, thespin_loop_v2
does not finish within 1 second, despite consuming around 100 million execution cost units.It's made possible by iterating an empty code block (except a
br
instruction), whereconsume_wasm_execution_units
host function becomes the dominant factor.This PR fixes it by introducing a base cost to account for the execution of the host function itself.