-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align WASM feature set in scrypto compiler #1973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrubasze
changed the title
Tweak/scrypto compiler reference types
Align WASM feature set in scrypto compiler
Oct 23, 2024
Docker tags |
Benchmark for 60c1375Click to view benchmark
|
iamyulong
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
lrubasze
force-pushed
the
tweak/scrypto-compiler-reference-types
branch
from
October 25, 2024 07:49
d3d97ee
to
f7b46f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since LLVM 19 below features are enabled by default (see release notes)
This PR makes sure that Scrypto compiler builds C dependencies with WASM
MVP
+mutable-global
+sign-ext
features (exactly as RadixEngine expects and exactly what Rust native libraries are built with) no matter what LLVM version is available on the system.NOTE!
Important takeaway is the fact that C dependencies are build with system LLVM, while native Rust libraries are built with LLVM built-in into Rust compiler.
Test
Relevant tests added