Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease max number of buffers #1972

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

iamyulong
Copy link
Member

Summary

Decrease max number of buffers from 32 to 4.

Copy link

github-actions bot commented Oct 23, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:7bc417dec2

Copy link

github-actions bot commented Oct 23, 2024

Benchmark for 7bc417d

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.9±0.18ms 44.9±0.30ms 0.00%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.4±0.09ms 19.6±0.02ms +1.03%
costing::decode_encoded_i8_array_to_manifest_value 40.8±0.05ms 41.5±0.06ms +1.72%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.0±0.10ms 63.3±0.06ms +0.48%
costing::decode_encoded_tuple_array_to_manifest_value 116.8±1.12ms 98.7±0.15ms -15.50%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.8±0.06µs 32.2±0.10µs +24.81%
costing::decode_encoded_u8_array_to_manifest_value 40.7±0.04ms 41.8±0.42ms +2.70%
costing::decode_rpd_to_manifest_raw_value 12.3±0.02µs 12.3±0.02µs 0.00%
costing::decode_rpd_to_manifest_value 10.9±0.02µs 10.9±0.01µs 0.00%
costing::deserialize_wasm 1221.3±5.30µs 1218.9±3.52µs -0.20%
costing::execute_transaction_creating_big_vec_substates 685.5±7.43ms 695.8±8.55ms +1.50%
costing::execute_transaction_reading_big_vec_substates 586.8±1.12ms 592.0±1.06ms +0.89%
costing::instantiate_flash_loan 1799.6±5368.57µs 1010.3±963.15µs -43.86%
costing::instantiate_radiswap 1045.2±1138.55µs 986.5±977.37µs -5.62%
costing::spin_loop 18.2±0.05ms 18.0±0.04ms -1.10%
costing::spin_loop_v2 2.7±0.03s 2.6±0.02s -3.70%
costing::spin_loop_v3 645.9±7.19ms 634.4±4.54ms -1.78%
costing::validate_sbor_payload 29.1±0.05µs 30.0±0.04µs +3.09%
costing::validate_sbor_payload_bytes 249.2±0.59ns 251.5±0.95ns +0.92%
costing::validate_secp256k1 76.5±0.04µs 76.6±0.06µs +0.13%
costing::validate_wasm 33.8±0.05ms 34.2±0.06ms +1.18%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.01ns 9.8±0.01ns 0.00%
decimal::add/wasmi 221.8±0.31ns 222.0±0.30ns +0.09%
decimal::add/wasmi-call-native 2.1±0.01µs 2.0±0.00µs -4.76%
decimal::div/0 165.3±0.14ns 165.3±0.11ns 0.00%
decimal::from_string/0 163.0±0.43ns 163.9±0.22ns +0.55%
decimal::mul/0 126.9±0.10ns 127.0±0.03ns +0.08%
decimal::mul/rust-native 123.1±0.16ns 122.9±0.14ns -0.16%
decimal::mul/wasmi 11.4±0.11µs 11.5±0.05µs +0.88%
decimal::mul/wasmi-call-native 2.2±0.00µs 2.2±0.00µs 0.00%
decimal::pow/0 576.9±0.23ns 577.0±0.18ns +0.02%
decimal::pow/rust-native 572.9±0.19ns 576.1±0.35ns +0.56%
decimal::pow/wasmi 56.0±0.30µs 56.9±0.18µs +1.61%
decimal::pow/wasmi-call-native 3.1±0.01µs 3.1±0.01µs 0.00%
decimal::root/0 8.1±0.01µs 8.1±0.00µs 0.00%
decimal::sub/0 8.2±0.03ns 8.3±0.02ns +1.22%
decimal::to_string/0 441.4±0.75ns 447.7±1.48ns +1.43%
large_transaction_processing::prepare 2.4±0.00ms 2.4±0.00ms 0.00%
large_transaction_processing::prepare_and_decompile 6.2±0.01ms 6.2±0.01ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 31.3±1.04ms 31.0±1.45ms -0.96%
metadata_validation::validate_urls 4.9±0.01µs 4.7±0.01µs -4.08%
precise_decimal::add/0 9.0±0.02ns 9.0±0.01ns 0.00%
precise_decimal::add/rust-native 10.8±0.05ns 10.6±0.01ns -1.85%
precise_decimal::add/wasmi 303.7±0.29ns 281.4±0.40ns -7.34%
precise_decimal::add/wasmi-call-native 2.8±0.00µs 2.7±0.01µs -3.57%
precise_decimal::div/0 278.8±0.62ns 278.5±0.40ns -0.11%
precise_decimal::from_string/0 202.7±0.29ns 202.4±0.37ns -0.15%
precise_decimal::mul/0 322.3±0.96ns 322.2±1.77ns -0.03%
precise_decimal::mul/rust-native 275.7±0.22ns 276.2±0.49ns +0.18%
precise_decimal::mul/wasmi 34.1±0.38µs 34.3±0.03µs +0.59%
precise_decimal::mul/wasmi-call-native 3.1±0.01µs 3.1±0.00µs 0.00%
precise_decimal::pow/0 1700.6±7.31ns 1705.3±4.76ns +0.28%
precise_decimal::pow/rust-native 1316.0±2.54ns 1317.1±1.24ns +0.08%
precise_decimal::pow/wasmi 161.8±0.60µs 160.5±2.17µs -0.80%
precise_decimal::pow/wasmi-call-native 5.3±0.01µs 5.4±0.01µs +1.89%
precise_decimal::root/0 57.5±0.14µs 57.6±0.12µs +0.17%
precise_decimal::sub/0 9.1±0.04ns 9.2±0.03ns +1.10%
precise_decimal::to_string/0 698.7±1.12ns 697.0±0.84ns -0.24%
schema::validate_payload 383.3±0.62µs 382.9±0.51µs -0.10%
transaction::radiswap 4.7±0.03ms 4.7±0.03ms 0.00%
transaction::transfer 1854.0±4.40µs 1825.9±3.23µs -1.52%
transaction_validation::validate_manifest 43.2±0.12µs 43.2±0.06µs 0.00%
transaction_validation::verify_bls_2KB 1090.9±16.92µs 1007.1±14.83µs -7.68%
transaction_validation::verify_bls_32B 1006.7±11.35µs 1008.9±19.01µs +0.22%
transaction_validation::verify_ecdsa 74.6±0.05µs 74.6±0.03µs 0.00%
transaction_validation::verify_ed25519 45.4±0.05µs 42.4±0.08µs -6.61%

use scrypto_test::prelude::*;

#[test]
fn test_crate_buffers_within_limits() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create*?

@iamyulong iamyulong merged commit 469d58f into develop Oct 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants