Forward form attribute to all form control elements
#3161
Merged
+27
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
requested review from
StephenHaney,
vladmoroz,
lucasmotta and
hadihallak
as code owners
chaance
commented
Oct 1, 2024
| @@ -88,6 +90,7 @@ const Slider = React.forwardRef<SliderElement, SliderProps>( | |||
| onValueChange = () => {}, | |||
| onValueCommit = () => {}, | |||
| inverted = false, | |||
| form, | |||
There was a problem hiding this comment.
A slider can render multiple thumbs with separate inputs. Form attribute should be shared, so lifting this one to the root.
lucasmotta
approved these changes
Oct 1, 2024
chaance
force-pushed
the
chance/suppport-form-attribute
branch
from
46d4eaf
to
50b363e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards the
formattribute to the underlying control elements for all Radix components that render a bubble input. Closes #2530.